ci: add markdown lint and link validation#20
Conversation
Adds two GitHub Actions jobs on every PR and push to master: - markdownlint-cli2: enforces consistent markdown style - lychee: checks all URLs return non-404 responses (3 retries with backoff) Includes .markdownlint.json disabling MD013 (line length) and MD033 (inline HTML) which would generate noise for a link-list repo. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 7 minutes and 25 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdded a GitHub Actions workflow that lints Markdown and checks links on pull requests and pushes to the master branch, a Markdownlint configuration file disabling MD013, MD033, and MD041, and removed several conference/scholarship entries from README.md lists. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lint: disable MD041 (first-line-heading) — README legitimately starts with a banner image, and PR/issue templates don't require an H1. Links: remove 10 dead URLs that no longer resolve: - JSConf USA (connection failed) - Microsoft Diversity Scholarships (redirects to 404) - Open Go (network error) - Out 4 Undergrad Tech (connection failed) - TAPIA Conference (connection failed) - Write, Speak, Code (connection failed) - GoCon (connection failed) - Serverlessdays Hamburg (connection failed) - Spring I/O (SSL certificate expired) - You Gotta Love Frontend Lithuania (connection failed) Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
There was a problem hiding this comment.
🧹 Nitpick comments (3)
.github/workflows/markdown-checks.yml (3)
3-7: Consider adding path filters for efficiency.The workflow triggers on all pull requests and pushes to master, even when no markdown files are modified. Adding path filters would prevent unnecessary workflow runs.
⚡ Proposed optimization
on: pull_request: branches: [master] + paths: + - '**.md' + - '.markdownlint.json' + - '.github/workflows/markdown-checks.yml' push: branches: [master] + paths: + - '**.md' + - '.markdownlint.json' + - '.github/workflows/markdown-checks.yml'🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/markdown-checks.yml around lines 3 - 7, The workflow currently triggers for every pull_request and push to master; narrow triggers by adding path filters under the existing on -> pull_request and on -> push keys (use the YAML keys pull_request, push and add a paths list) to only run when markdown files change (e.g., include patterns like '**/*.md' and '.github/**/*.md'); update the .github/workflows/markdown-checks.yml to include these paths entries for both pull_request and push to avoid unnecessary runs.
25-39: Consider SHA pinning for the lychee action.The link-check configuration looks well-structured with appropriate timeout and retry settings. The
--exclude "mailto:"is correct since mailto links aren't HTTP(S) endpoints.For security, consider pinning to a specific commit SHA instead of the
@v2tag to prevent supply chain attacks from tag updates. For example:uses: lycheeverse/lychee-action@7da8ec1fc4e01b5a12062ac6c589c10a4ce70d67. You can use Dependabot to automate SHA updates.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/markdown-checks.yml around lines 25 - 39, Replace the floating tag for the lychee action usage (currently referenced as lycheeverse/lychee-action@v2) with a specific commit SHA to hard-pin the action; update the GitHub Action step that uses lycheeverse/lychee-action@v2 to use a concrete commit hash (e.g. the example 7da8ec1fc4e01b5a12062ac6c589c10a4ce70d67) and consider adding Dependabot to keep that SHA updated automatically.
14-19: Consider pinning to commit SHAs and update markdownlint action to latest version.The workflow uses mutable version tags (
@v4,@v16) which can be updated by maintainers without notice. For improved security and reproducibility, pin to specific commit SHAs instead (e.g.,actions/checkout@b4c9fea...).Additionally,
DavidAnson/markdownlint-cli2-action@v16is outdated; the latest version is v23.0.0. Update to the current version for bug fixes and improvements.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/markdown-checks.yml around lines 14 - 19, Replace mutable action tags with pinned commit SHAs: update the uses references for actions/checkout and DavidAnson/markdownlint-cli2-action (the current uses entries "actions/checkout@v4" and "DavidAnson/markdownlint-cli2-action@v16") to their corresponding commit SHA pins, and bump the markdownlint action to the latest release (v23.0.0) before pinning; keep the same inputs (e.g., the "globs" input) unchanged while ensuring the new pinned SHAs match the chosen versions.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/markdown-checks.yml:
- Around line 3-7: The workflow currently triggers for every pull_request and
push to master; narrow triggers by adding path filters under the existing on ->
pull_request and on -> push keys (use the YAML keys pull_request, push and add a
paths list) to only run when markdown files change (e.g., include patterns like
'**/*.md' and '.github/**/*.md'); update the
.github/workflows/markdown-checks.yml to include these paths entries for both
pull_request and push to avoid unnecessary runs.
- Around line 25-39: Replace the floating tag for the lychee action usage
(currently referenced as lycheeverse/lychee-action@v2) with a specific commit
SHA to hard-pin the action; update the GitHub Action step that uses
lycheeverse/lychee-action@v2 to use a concrete commit hash (e.g. the example
7da8ec1fc4e01b5a12062ac6c589c10a4ce70d67) and consider adding Dependabot to keep
that SHA updated automatically.
- Around line 14-19: Replace mutable action tags with pinned commit SHAs: update
the uses references for actions/checkout and DavidAnson/markdownlint-cli2-action
(the current uses entries "actions/checkout@v4" and
"DavidAnson/markdownlint-cli2-action@v16") to their corresponding commit SHA
pins, and bump the markdownlint action to the latest release (v23.0.0) before
pinning; keep the same inputs (e.g., the "globs" input) unchanged while ensuring
the new pinned SHAs match the chosen versions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cea041ff-6c65-4b88-91f0-5fad8519d3fb
📒 Files selected for processing (2)
.github/workflows/markdown-checks.yml.markdownlint.json
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Link Check
🔇 Additional comments (1)
.markdownlint.json (1)
1-5: LGTM! Configuration aligns with PR objectives.The markdownlint configuration appropriately disables MD013 (line-length) and MD033 (inline HTML) while enabling all other rules by default. This is a sensible choice for a link-list repository where these rules could generate excessive noise.
The site actively resets connections from CI runner IPs but is live. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Remove 404s: - AWS re:Invent diversity grant page (update to homepage) - Clojure/Conj opportunity page - LocoMocoSec diversity page - RailsConf scholarships page - PHP UK Conference diversity page Add to .lycheeignore (live but block CI crawler requests): - racketfest.com - harvardwecode.com - diversitytickets.org Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
markdownlint-cli2to enforce consistent markdown style across all.mdfileslycheeto check every URL in markdown files doesn't return a 404.markdownlint.jsonconfig disabling line-length (MD013) and inline HTML (MD033) rules — both would produce constant noise in a link-list repoTest plan
🤖 Generated with Claude Code